search

IBM / go-sdk-core

The go-sdk-core repository contains core functionality required by Go code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
30 stars 24 forks source link

feat: add unmarshal utility functions for primitive types #46

Closed padamstx closed 4 years ago

padamstx commented 4 years ago

Fixes: https://github.ibm.com/arf/planning-sdk-squad/issues/1148

This PR adds some utility methods for unmarshalling primitive types. These additions are part of the renovation of the Go generator to change the way in which we de-serialize operation response bodies, which will also allow us to more easily support discriminators.

Edit: as part of this PR, I also got rid of the "v3" version directory (everything that was in "v3" was just moved up to the root of the project). I had initially created the "v3" directory when I created the v3.0.0 major version of the core because my understanding was that the version directory was a firm requirement when creating a new major version of a go package (module). It turns out that it's not quite as firm as I was led to believe :) The actual requirement is that there must be a go.mod file in the project root directory or one of its subdirectories that contains module github.com/IBM/go-sdk-core/v3 at the top. It doesn't have to be located in the "v3" directory. Also, this change will allow us to continue to use semantic-release.

padamstx commented 4 years ago

@mkistler This PR is a prereq to the go discriminator work in the generator. I wanted to make sure you had something to do on the plane ride back home tomorrow :)

padamstx commented 4 years ago

@mkistler I've addressed your review comments. Ready for another look.

ibm-devx-automation commented 4 years ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: