fix: tolerate explicit JSON null values in UnmarshalXXX() methods

IBM / go-sdk-core

The go-sdk-core repository contains core functionality required by Go code generated by the IBM OpenAPI SDK Generator.

Apache License 2.0

30 stars 24 forks source link

fix: tolerate explicit JSON null values in UnmarshalXXX() methods #52

Closed padamstx closed 4 years ago

padamstx commented 4 years ago

Fixes: https://github.ibm.com/arf/planning-sdk-squad/issues/1517 Fixes: https://github.ibm.com/ibmcloud/platform-services-go-sdk/issues/14

This PR adds an explicit nil check when retrieving properties from a map inside the various UnmarshalXXX() methods. Previously, we were checking for the existence of the property in the map, but did not consider the possibility that the value of the property is the JSON null value.

ibm-devx-automation commented 4 years ago

:tada: This PR is included in version 3.2.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: