IBM / graph2tac

Graph-based neural tactic prediction models for Coq.
Apache License 2.0
10 stars 5 forks source link

Stop returning values in entry points and improve predict server tests #143

Closed jasonrute closed 1 year ago

jasonrute commented 1 year ago

Change 1: No longer return values in g2t-tfgnn-train, g2t-server, and g2t-hmodel-train. These would be treated as errors and cluttered output. But the values can still be used for tests.

Change 2: Change the format of the predict server expected outputs. There were two problems:

mirefek commented 1 year ago

Is the hmodel-predict-server supposed to work now? It still doesn't for me but you changed some of the relevant files (so I am not sure what the change is about).

jasonrute commented 1 year ago

@mirefek Sorry, I should have made clear, I manually changed all the expected-predict-server.yaml files with a script. That way I could be sure the results are the same except for the permutation of the order the results are listed in (if there is a tie in the confidence). That is why the hmodel server expected results file changed even though the test is still broken.

mirefek commented 1 year ago

I see