IBM / guestbook

Apache License 2.0
68 stars 226 forks source link

Remove any hardcoded strings in Docker and deployment files #6

Open cmluciano opened 6 years ago

cmluciano commented 6 years ago

Most of the files have hardcoded docker and infrastructure strings. These need to be removed in favor of a script that accepts variables.

MHBauer commented 6 years ago

Which specific strings?

cmluciano commented 6 years ago

hardcoded variables that can probably be reverted to using env vars use env vars instead of needing to pass the whole sting ideally a root Makefile or script can auto-fill these based on env var