use deployments and not replicacontrollers

[MHBauer]

from the docs: NOTE: A Deployment that configures a ReplicaSet is now the recommended way to set up replication.

[duglin]

@linsun any objection to this change?

[linsun]

@duglin no objection but would prefer only in v2 of the service... so we can keep v1 to be vanilla from the original guestbook.

[MHBauer]

Why? What educational purpose does it serve?

Where is the original?

[cmluciano]

+1 to switching to deployments, it's often confusing to say "forget everything I just said about replicasets and now let's use deployments"

[linsun]

original is from k8s repo. the purpose is to show people you can take the sample as it is with very minimum change and deploy within istio.

[MHBauer]

Well, now it's our sample code, so let's make it use best practices. Everything possible with replicacontrollers should be possible with deployments.

[linsun]

right, that is why i'm all for the change in v2. for v1, the focus is to show people they can bring services onto istio easily with very few changes. this shows people starts with something they have it working (which maybe designed for slightly older version of k8s) but users can modernize it in v2.

[MHBauer]

I'm not going to teach people that for a workshop. Maybe we need a vLegacy as well.

[linsun]

for the record, I'm ok with changing it in v1 and v2 to keep it simple given many of you shared concerns on using RCs.

[frankbu]

I absolutely agree it should be changed to Deployment in all versions. Nobody cares about RCs anymore. Anybody using them these days is misguided.

[MHBauer]

dibs

[MHBauer]

resolved by #13