search

IBM / ibm-common-service-operator

Operator to install IBM Common Services
https://www.ibm.com/support/knowledgecenter/SSHKN6/kc_welcome_cs.html
Apache License 2.0
19 stars 67 forks source link

skip clean control namespace in rerun #2083

Closed qpdpQ closed 2 months ago

qpdpQ commented 2 months ago

What this PR does / why we need it: we should skip cleanup control namespace when common-service-maps configmap does not exist in the cluster. Which issue(s) this PR fixes: Fixes # https://github.ibm.com/ibmprivatecloud/roadmap/issues/63743

Daniel-Fan commented 2 months ago

Hi @qpdpQ

At the beginning of the script, could we initialize CONTROL_NS to a default "" value?, So we will not hit error CONTROL_NS: unbound variable

TENANT_NAMESPACES=""
OPERATOR_NS_LIST=""
CONTROL_NS=""
qpdpQ commented 2 months ago

Sure! Just add it

ibm-ci-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, qpdpQ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/IBM/ibm-common-service-operator/blob/scripts-dev/OWNERS)~~ [Daniel-Fan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Daniel-Fan commented 2 months ago

/lgtm