search

IBM / ibm-cos-sdk-js

ibm-cos-sdk-js
Apache License 2.0
38 stars 20 forks source link

uuid 3.4.0 is deprecated #89

Closed mriedem closed 2 years ago

mriedem commented 2 years ago

I'm using ibm-cos-sdk 1.10.2 which depends on uuid@3.4.0 which is deprecated:

npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

I'm not sure if there is any breaking change in uuid@7 for ibm-cos-sdk but if not it'd be nice to upgrade to avoid that deprecation warning.

mriedem commented 2 years ago

Also FYI https://github.com/defunctzombie/node-url/issues/57 - if ibm-cos-sdk could get away with not requiring that url dependency and instead use the URL module in nodejs directly that'd be a win IMO.

sp1tz commented 2 years ago

I'm using ibm-cos-sdk 1.10.2 which depends on uuid@3.4.0 which is deprecated:

npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

I'm not sure if there is any breaking change in uuid@7 for ibm-cos-sdk but if not it'd be nice to upgrade to avoid that deprecation warning.

Same here. uuid skipped version numbers 4, 5, & 6 to avoid confusion w/ the RFC: https://www.npmjs.com/package/uuid#upgrading-from-uuid3x

A quick grep of the code shows it only used in a single source file: https://github.com/IBM/ibm-cos-sdk-js/blob/master/lib/util.js#L952

All that leads me to believe the update should be straightforward w/o breakage.

IBMeric commented 2 years ago

This change came in too late for the 1.11.0 release but is currently staged for the next one.

AWare commented 2 years ago

@IBMeric when is this planned please?

IBMalok commented 2 years ago

@AWare - It will be available at end of the second quarter.

IBMalok commented 2 years ago

@AWare We have released 1.12.0 and this issue got addressed. Please verify and close this ticket.

mriedem commented 2 years ago

We have released 1.12.0 and this issue got addressed. Please verify and close this ticket.

Yup looks good, thanks.

$ npm list uuid
sw-ibmq-results@0.53.2 /home/osboxes/ibmq/sw-ibmq-results
├─┬ ibm-cos-sdk@1.12.0
│ └── uuid@7.0.3 deduped
└── uuid@7.0.3