IBM / ibm-licensing-operator

Operator for IBM License Service
Other
24 stars 27 forks source link

Namespace field missing from config/manager/manager.yaml when using offline install for stand-alone IBM Containerized Software #670

Open psdally opened 2 years ago

psdally commented 2 years ago

The instructions here: https://www.ibm.com/docs/en/cpfs?topic=software-offline-installation

Using latest branch (at the time 1.16.3), in point 3e, it indicates to use kubectl to apply config/manager/manager.yaml to the Kubernetes cluster. This file, however, includes a Deployment definition that does not include a namespace name in the metadata:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: ibm-licensing-operator
spec:
<snip>

Unless the user has specified a default Namespace for kubectl of ibm-common-services, this will be deployed to whatever their default Namespace happens to be (typically "default", but could be other values as well).

The Deployment, however, references a serviceAccountName: ibm-licensing-operator , which is defined in config/rbac/service_account.yaml - and this ServiceAccount does specify the ibm-common-services namespace. As a result, the Deployment does not work.

To be consistent with the other manifests, the Deployment defined in config/manager/manager.yaml should have a namespace attribute of ibm-common-services added to the metadata.

pgodowski commented 2 years ago

While the issue looks generic, can you please clarify which IBM product is being required to track license usage?