IBM / ibm-spectrum-scale-bridge-for-grafana

This tool allows the IBM Storage Scale users to perform performance monitoring for IBM Storage Scale devices using third-party applications such as Grafana or Prometheus software.
Apache License 2.0
30 stars 17 forks source link

Add Basic Auth support to Prometheus Brigde #188

Closed SckyzO closed 5 months ago

SckyzO commented 6 months ago

Would it be possible to add "Basic Auth" authentication (https://prometheus.io/docs/guides/basic-auth/) for security reasons?

Helene commented 6 months ago

I'll discuss with the team if we can support this approach. Also I need to verify if we can use https://pypi.org/project/bcrypt/ since it is not a package of Python standard library.

SckyzO commented 6 months ago

Hello,

Another way, it would be to use a reverse proxy like nginx with container mode. it's maybe more easy to integrate a reverse proxy in a docker/podman compose ?

With Nginx we can use basic auth and TLS

Helene commented 5 months ago

resolved by #201

Related documentation: https://github.com/IBM/ibm-spectrum-scale-bridge-for-grafana/wiki/Setup-the-IBM-Spectrum-Scale-Performance-Monitoring-Bridge-for-classic-IBM-Spectrum-Scale-devices https://github.com/IBM/ibm-spectrum-scale-bridge-for-grafana/blob/master/examples/prometheus_config_file/prometheus_with_basic_auth.yml