Closed amdabhad closed 1 month ago
@deeghuge, @Jainbrt there should be a better review process in CSI, dev should not spend time on fixing review comments every day.
@Jainbrt, you are added as a reviewer 2 weeks back, why are you adding comments immediately after dev approval? Please open defect if you disagree.
@Jainbrt, you are added as a reviewer 2 weeks back, why are you adding comments immediately after dev approval? Please open defect if you disagree.
@amdabhad these are valid comment. lets address those as an issue.
@Jainbrt, unless it's a blocker issue, we will not change anything in this PR now. Please record your findings in the issues, we will address which are valid ones, thanks!
@deeghuge @hemalathagajendran - Test team covered testing of this PR and is completed with no blockers at this moment.Good to go for merge. Thanks!
Add support for AFM cache volume
quay.io/amdabhad/csi-driver:afmCaching3041quay.io/amdabhad/csi-driver:afmCaching3053 (with review comments + some improvements)quay.io/amdabhad/csi-driver:afmCaching3065 (With fix for secret mask - scale-core#7094)Signed-off-by: amdabhad amdabhad@in.ibm.com Co-authored-by: jacohn16 jeremy.cohn@ibm.com
Please check the type of change your PR introduces:
How risky is this change?