IBM / ibm-spectrum-scale-csi

The IBM Spectrum Scale Container Storage Interface (CSI) project enables container orchestrators, such as Kubernetes and OpenShift, to manage the life-cycle of persistent storage.
Apache License 2.0
64 stars 50 forks source link

Add AFM cache volume support #1161

Closed amdabhad closed 1 month ago

amdabhad commented 1 month ago

Add support for AFM cache volume

Signed-off-by: amdabhad amdabhad@in.ibm.com Co-authored-by: jacohn16 jeremy.cohn@ibm.com

Please check the type of change your PR introduces:

How risky is this change?

amdabhad commented 1 month ago

@deeghuge, @Jainbrt there should be a better review process in CSI, dev should not spend time on fixing review comments every day.

amdabhad commented 1 month ago

@Jainbrt, you are added as a reviewer 2 weeks back, why are you adding comments immediately after dev approval? Please open defect if you disagree.

deeghuge commented 1 month ago

@Jainbrt, you are added as a reviewer 2 weeks back, why are you adding comments immediately after dev approval? Please open defect if you disagree.

@amdabhad these are valid comment. lets address those as an issue.

amdabhad commented 1 month ago

@Jainbrt, unless it's a blocker issue, we will not change anything in this PR now. Please record your findings in the issues, we will address which are valid ones, thanks!

Pratibhajoshi commented 1 month ago

@deeghuge @hemalathagajendran - Test team covered testing of this PR and is completed with no blockers at this moment.Good to go for merge. Thanks!