search

IBM / ibm-spectrum-scale-csi

The IBM Spectrum Scale Container Storage Interface (CSI) project enables container orchestrators, such as Kubernetes and OpenShift, to manage the life-cycle of persistent storage.
Apache License 2.0
68 stars 49 forks source link

Make primaryFset, clusterId and scaleHostpath params optional in driver configuration yaml file #20

Closed przem123 closed 4 years ago

przem123 commented 4 years ago

When I create an instance of a CSI driver, I need to edit a yaml file. There, I need to specify primaryFset and scaleHostpath.

I would expect that if I do not specify primaryFset then the driver/operator would create automatically a generic fset in my filesystem.

For scaleHostpath, the operator/ driver could obtain it from the Spectrum Scale GUI via REST API, so I think you should not require the user to remember and insert the path.

Can you make both of the parameters optional ? This would simplify the configuration.

przem123 commented 4 years ago

I think, you could also make clusterId optional in the yaml file, as it can be obtained via Rest Api as well.

mew2057 commented 4 years ago

This is a long term goal, we'll shoot for it in 1.0.1, however, that release is intended for cert to the IBM Cloud Pak, so new features are not planned at this time.

przem123 commented 4 years ago

This would be a very useful fix which would improve the usability of the CSI significantly. Hope you could include it in one of the upcoming releases.

mew2057 commented 4 years ago

I'm targeting 1.0.2 or 1.0.3 for this.

deeghuge commented 4 years ago
gandhisanjayv commented 4 years ago

will it impact upgrade and restart of csi driver? it tries to creates primaryFset during csi driver pod start.

deeghuge commented 4 years ago

@gandhisanjayv

will it impact upgrade and restart of csi driver? it tries to creates primaryFset during csi driver pod start.

It will not impact the upgrade because for older deployment primaryFset was there and it will be continue to be there after upgrade and provided value will be used. For new deployment if primaryFset is not given, fileset will be created using default fileset name and if given it will use the specified name.

gandhisanjayv commented 4 years ago

how do we ensure that default fileset name is not managed by other user?

deeghuge commented 4 years ago

how do we ensure that default fileset name is not managed by other user?

We are documenting the default name. current default name we are thinking of is spectrum-scale-csi-volume-store.

Jainbrt commented 4 years ago

@deeghuge fixed in 2.0.0, we can close this now.