search

IBM / ibm-spectrum-scale-install-infra

Spectrum Scale Installation and Configuration
Apache License 2.0
65 stars 69 forks source link

Needs to add minimum supported Ansible version in the README #75

Open rajan-mis opened 4 years ago

rajan-mis commented 4 years ago

Needs to add minimum supported Ansible version in the README

rajan-mis commented 4 years ago

@digvijay2016 Thanks

rajan-mis commented 4 years ago

@digvijay2016 Thanks

rajan-mis commented 4 years ago

We are seeing our playbook failure on ansible 2.4.2.0

mamuthiah commented 4 years ago

@rajan-mis Instead of putting this requirement into the README, can we put this as an assert directly into the code? Thanks.

rajan-mis commented 4 years ago

@mamuthiah Yes we can do that. thanks

troppens commented 4 years ago

I recommend both: prerequisite section in README and check in code

whowutwut commented 4 years ago

I'm torn here, i understand why we would want to put a pre-req on the minimum, but are we actually going to be continually testing with that minimum version to validate that it holds true... otherwise we would never know when we started using a module that isn't provided at that min version -- until someone reports it.

rajan-mis commented 4 years ago

I have seen multiple failure with ansible version less than 2.7 . The same failure is happening on ubuntu and sles when i was doing unit testing of ubuntu and sles ansible code . I already implemented this validation and planning to create PR.

mrolyat commented 4 years ago

Hit this on RHEL7.8 node. It appears that the Red Hat extras repo for RHEL7.x only goes up to ansible 2.4.2.0: https://access.redhat.com/downloads/content/rhel---7/x86_64/3030/ansible/2.4.2.0-2.el7/noarch/fd431d51/package

This would imply any RHEL7.x nodes to install ansible from some other location.

mrolyat commented 4 years ago

Marking this as must fix:

  1. need to update README with minimum supported ansible version
  2. should provide guidance on where to get proper ansible version for RHEL7.x nodes that do no have access to >=2.7 ansible in their extras repos
  3. query underlying ansible version (and if it's installed) during prechecks and provide good problem determination guidance
acch commented 4 years ago

Re.: 3. Query underlying ansible version (and if it's installed) during prechecks

Ansible Galaxy has the concept of role metadata (defined in meta/main.yml), which also includes a min_ansible_version. Running ansible-galaxy install without the required version of Ansible will fail with an appropriate message.

One advantage of distributing the code through Galaxy... #106