IBM / ibm-storage-odf-console

ibm-storage-odf-console provides IBM storage specific console page, which will be loaded by ODF console when end users access IBM storage. It's specially designed for displaying IBM specific storage attributes to customer. Current scope includes IBM flashsystem only.
Apache License 2.0
3 stars 7 forks source link

Fix various dependencies and Route issues #105

Closed SanjalKatiyar closed 3 months ago

SanjalKatiyar commented 3 months ago

Before:

image

After:

Screenshot 2024-07-22 at 2 40 17 PM

What's next:

Earlier it was showing 404: Page not found, which is now fixed. But, it's now showing Oh no! Something went wrong.. Need to send a follow-up PR to fix that: React Router v5 to v6 migration. Please check: https://github.com/red-hat-storage/odf-console/pull/1125 for more details.

PS: there should be a way to make it work with React Router v5 itself (a temporary fix), but eventually (OCP 4.16 onwards) we have to move to v6 anyway, so better to incorporate that now itself else it will break again next release.

SanjalKatiyar commented 3 months ago

To add bit more of a context, if we check the error in the above screenshots it states: "undefined params". This is because props here: https://github.com/IBM/ibm-storage-odf-console/blob/main/src/flashsystem-dashboard.tsx#L88 might be missing those fields.

^ consider this as a starting point for further debugging...