Closed SanjalKatiyar closed 3 months ago
To add bit more of a context, if we check the error in the above screenshots it states: "undefined params". This is because props
here: https://github.com/IBM/ibm-storage-odf-console/blob/main/src/flashsystem-dashboard.tsx#L88 might be missing those fields.
props
and remove the dependencies on items which are not part of the props now (eg: history
, match
etc).history
, match
etc then ? You can directly use React Router
lib (check the PR's description).props
are shared by other components as well: https://github.com/IBM/ibm-storage-odf-console/blob/main/src/flashsystem-dashboard.tsx#L126, so we need to update all such components.^ consider this as a starting point for further debugging...
Before:
After:
What's next:
Earlier it was showing
404: Page not found
, which is now fixed. But, it's now showingOh no! Something went wrong.
. Need to send a follow-up PR to fix that: React Router v5 to v6 migration. Please check: https://github.com/red-hat-storage/odf-console/pull/1125 for more details.PS: there should be a way to make it work with
React Router v5
itself (a temporary fix), but eventually (OCP 4.16 onwards) we have to move to v6 anyway, so better to incorporate that now itself else it will break again next release.