search

IBM / ibmcloud-object-storage-plugin

IBM Cloud Object Storage plugin is a Kubernetes volume plugin that enables Kubernetes pods to access IBM Cloud Object Storage buckets. The plugin has two components: a dynamic provisioner and a FlexVolume driver for mounting the buckets using s3fs-fuse on a worker node.
Apache License 2.0
56 stars 42 forks source link

update curldbg to support body option and support additional mount options as annotation from pvc spec #103

Closed ambiknai closed 2 years ago

ambiknai commented 2 years ago
  1. update curldbg to support body option Refer: https://github.com/s3fs-fuse/s3fs-fuse/pull/1295

Approach:

We will set "body" option as parameter when curldbg is set to true from PVC

Details

Added a parameter to output body to curldbg option.

The curldbg option can be specified by curldbg=normal, curldbg=body or the same curldbg as before.
If the parameter is omitted, it is the same as normal.

curldbg or curldbg=normal is the same debug output as before.
When curldbg=body is specified, in addition to this debug output, the request body of CompleteMultipartUpload and the response body of ListObjects are output.

In this PR, output body is limited to a specific API.
In the future, if necessary, we will add APIs or change the APIs to output body output.
  1. support additional mount options as annotation from pvc spec 
    In PVC Spec user can add more mount options as below.
`ibm.io/add-mount-param: "-o opt1 -o opt2"`
These user provided parameters are not validated from code and are passed as a string to s3fs command