IBM / ibmichroot

A set of scripts to facilitate the use of chroot-based containers for IBM i
MIT License
22 stars 10 forks source link

Need to rebuild (or stop using) tar files #61

Closed ThePrez closed 3 years ago

ThePrez commented 5 years ago

I've run into several occasions where chroots were braindead, but it was remedied by running: rm -f /QOpenSys/pkgs/lib/ibmichroot/config/*.tar I suspect the .tar files get out of sync with the installed PASE version. I propose we rebuild the .tar files on every invocation and incur the performance overhead cost for the sake of usability.

kadler commented 5 years ago

My understanding is that the tar files are only there to speed up later invocations. If we're going to rebuild them everytime, there's no point to even creating them.

abmusse commented 5 years ago

Ok I will open a PR removing lines where we create the tar file and also check that it exists.

abmusse commented 5 years ago

@kadler @ThePrez

If we are no longer caching the created tar files

Then it looks like we wont need the chroot_tar_dir function.

its used whenever :tar_dir is located in a .lst:

We can instead us chroot_cp_dir, which simply copies the target dir into the chroot.

Probably can just change all instances of :tar_dir in .lst files -> :cp_dir.

Then we can safely remove the chroot_tar_dir function