search

IBM / ibmichroot

A set of scripts to facilitate the use of chroot-based containers for IBM i
MIT License
21 stars 9 forks source link

Alternative download pkg_setup.sh on Linux is broken because PATH change #8

Closed abmusse closed 9 years ago

abmusse commented 9 years ago

Original report by PHPDave (Bitbucket: PHPDave, GitHub: PHPDave).

Recent commit breaks alternative download specified in http://yips.idevcloud.com/wiki/index.php/PASE/OpenSourceBeta#step0

Should either 1) remove alternative download in Wiki or 2) check to see if the script is running on IBMi before setting the PATH and LIBPATH or 3) create a different script for downloading files via an intermediate machine.

Commit Diff: https://bitbucket.org/litmis/ibmichroot/diff/pkg_setup.sh?diff2=4ee0137bbc85&at=master

Proposed solution

#!shell

system_OS400=$(uname | grep -c OS400)

# set PATH and LIBPATH to avoid user random acts
if (($system_OS400==1))
then
    PATH=/QOpenSys/usr/bin:/QOpenSys/usr/sbin
    LIBPATH=/QOpenSys/usr/lib
    export PATH
    export LIBPATH
fi
abmusse commented 9 years ago

Original comment by Aaron Bartell (Bitbucket: aaronbartell, GitHub: aaronbartell).

That worked and your changes are now merged into the base repo. COOL!

Please continue to test/kick-tires. The success of projects like this are very much dependent on many community members participating.

abmusse commented 9 years ago

Original comment by PHPDave (Bitbucket: PHPDave, GitHub: PHPDave).

Ok I figured it out! https://confluence.atlassian.com/display/BITBUCKET/Fork+a+Repo,+Compare+Code,+and+Create+a+Pull+Request

abmusse commented 9 years ago

Original comment by Aaron Bartell (Bitbucket: aaronbartell, GitHub: aaronbartell).

It appears you did a pull request to your own repository and it needs to be a pull request to the original ibmichroot repo so I can merge it into the ibmichroot project.

abmusse commented 9 years ago

Original comment by PHPDave (Bitbucket: PHPDave, GitHub: PHPDave).

Ok i tried it two different ways... forked it myself and then did an automated fork... Let me know if i did anything wrong.

abmusse commented 9 years ago

Original comment by Aaron Bartell (Bitbucket: aaronbartell, GitHub: aaronbartell).

Nevermind, I didn't read your post full (i.e. proposed solution). Solution looks good. Please fork, make change, and do pull request. If you don't know how to do that I can teach you.

abmusse commented 9 years ago

Original comment by Aaron Bartell (Bitbucket: aaronbartell, GitHub: aaronbartell).

Recent commit breaks alternative download specified in http://yips.idevcloud.com/wiki/index.php/PASE/OpenSourceBeta#step0

Need more info concerning what broke (i.e. shell error listing) so I don't have to go hunting. Before adding PATH and LIBPATH it was breaking when installing git because the install process was introducing new paths that broke grep (which is used in chroot_setup.sh).