search

IBM / java-sdk-core

Core functionality required by Java code generated by the IBM Cloud OpenAPI SDK Generator (openapi-sdkgen)
https://ibm.github.io/java-sdk-core/
Apache License 2.0
20 stars 21 forks source link

chore: Improve unit test coverage #128

Closed Andras-Csanyi closed 3 years ago

Andras-Csanyi commented 3 years ago

This PR contains 100% unit test coverage against BooleanToStringTypeAdapter.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

Andras-Csanyi commented 3 years ago

Let's hold off on this PR for a while.

padamstx commented 3 years ago

@Andras-Csanyi I don't want to burst your bubble, however... :) I did a quick search and it looks like we do not actually use the BooleanToStringTypeAdapter. Perhaps at one time (before I joined the team) we did in fact register that type adapter with Gson, but it looks like we currently do not. With that in mind, I think the best way to handle this one is to simply delete the class, rather than add testcases for it.
Edit: I'm going to change my mind on this one after thinking about it a little more. Because this class is part of the "official" java core API, we can't just delete it from the library. So, please proceed to add your tests for it :)

Perhaps we can meet up on webex and take a look at the jacoco report to see where we can achieve the "biggest bang for the buck" in terms of improving test coverage. For example, the jacoco report doesn't include any test coverage for the CloudPakForDataServiceAuthenticator despite the fact that its tests appear to be run during the "mvn test" phase. Not sure why those tests are not contributing any test coverage data. Also, there are probably a few other classes that are causing the coverage numbers to be dragged down.

ibm-devx-sdk commented 3 years ago

:tada: This PR is included in version 9.11.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: