IBM / jsonsubschema

Tool for checking whether a JSON schema is a subschema of another JSON schema.
Apache License 2.0
82 stars 17 forks source link

Fix couple of trivial cases for TOP schemas #15

Closed andrewhabib closed 11 months ago

andrewhabib commented 11 months ago

This PR fixes the follow-up issue mentioned in #14 by doing the following:

I have also added a couple of test cases that check for this specific case.

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08% :tada:

Comparison is base (9c84182) 76.54% compared to head (56df57e) 76.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #15 +/- ## ========================================== + Coverage 76.54% 76.63% +0.08% ========================================== Files 8 8 Lines 1390 1395 +5 Branches 413 415 +2 ========================================== + Hits 1064 1069 +5 Misses 232 232 Partials 94 94 ``` | [Files Changed](https://app.codecov.io/gh/IBM/jsonsubschema/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=IBM) | Coverage Δ | | |---|---|---| | [jsonsubschema/\_canonicalization.py](https://app.codecov.io/gh/IBM/jsonsubschema/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=IBM#diff-anNvbnN1YnNjaGVtYS9fY2Fub25pY2FsaXphdGlvbi5weQ==) | `93.65% <100.00%> (ø)` | | | [jsonsubschema/\_checkers.py](https://app.codecov.io/gh/IBM/jsonsubschema/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=IBM#diff-anNvbnN1YnNjaGVtYS9fY2hlY2tlcnMucHk=) | `71.65% <100.00%> (+0.09%)` | :arrow_up: | | [jsonsubschema/\_constants.py](https://app.codecov.io/gh/IBM/jsonsubschema/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=IBM#diff-anNvbnN1YnNjaGVtYS9fY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrewhabib commented 11 months ago

Closing it and reopening a new one to solve the signing issue.