IBM / jsonsubschema

Tool for checking whether a JSON schema is a subschema of another JSON schema.
Apache License 2.0
82 stars 17 forks source link

Remove the unnecessary dependency: numpy #17

Closed MrLYC closed 10 months ago

MrLYC commented 10 months ago

I noticed that jsonsubschema introduced numpy to create a specialized branch of support. In fact, this is unnecessary because Python already provides a simpler implementation.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% :tada:

Comparison is base (9c84182) 76.54% compared to head (ff6bc10) 76.56%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17 +/- ## ========================================== + Coverage 76.54% 76.56% +0.01% ========================================== Files 8 8 Lines 1390 1391 +1 Branches 413 413 ========================================== + Hits 1064 1065 +1 Misses 232 232 Partials 94 94 ``` | [Files Changed](https://app.codecov.io/gh/IBM/jsonsubschema/pull/17?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=IBM) | Coverage Δ | | |---|---|---| | [jsonsubschema/\_canonicalization.py](https://app.codecov.io/gh/IBM/jsonsubschema/pull/17?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=IBM#diff-anNvbnN1YnNjaGVtYS9fY2Fub25pY2FsaXphdGlvbi5weQ==) | `93.68% <100.00%> (+0.03%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shinnar commented 10 months ago

Hi @MrLYC ! Thanks for submitting this PR, it looks good to me. In order to merge it in, we need a signed DCO: https://github.com/IBM/jsonsubschema/blob/master/DCO1.1.txt This just certifies that the code changes are original and that you are allowed and willing to license them under the Apache-2.0 license

MrLYC commented 10 months ago

Done, looking forward to the release of the new version.

hirzel commented 10 months ago

Dear @MrLYC , thank you for your contribution! Could you please email me a copy of the signed DCO at hirzel@us.ibm.com ?

MrLYC commented 10 months ago

@hirzel I have sent an email, is the format and content correct?

hirzel commented 10 months ago

Yes, received with thanks!