Closed MrLYC closed 10 months ago
Patch coverage: 100.00%
and project coverage change: +0.01%
:tada:
Comparison is base (
9c84182
) 76.54% compared to head (ff6bc10
) 76.56%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @MrLYC ! Thanks for submitting this PR, it looks good to me. In order to merge it in, we need a signed DCO: https://github.com/IBM/jsonsubschema/blob/master/DCO1.1.txt This just certifies that the code changes are original and that you are allowed and willing to license them under the Apache-2.0 license
Done, looking forward to the release of the new version.
Dear @MrLYC , thank you for your contribution! Could you please email me a copy of the signed DCO at hirzel@us.ibm.com ?
@hirzel I have sent an email, is the format and content correct?
Yes, received with thanks!
I noticed that jsonsubschema introduced numpy to create a specialized branch of support. In fact, this is unnecessary because Python already provides a simpler implementation.