Closed kmichel-aiven closed 4 weeks ago
Thanks for the PR! This looks good, and I would be happy to merge it. However, as this is your first commit, before we can merge in the code, we need a signed DCO on record: https://github.com/IBM/jsonsubschema/blob/master/DCO1.1.txt Could you please sign and email this to hirzel@us.ibm.com
Hi, I've sent the DCO and got an acknowledgment.
There are already some places where the calling code takes care of avoiding
.*
and just useNone
. However, this was not done in_joinString
and was producing a trivial.{0,}
causing slow calls toregex_meet
.A sample schema that is made faster by this change is:
Which takes ~6sec to be compared with itself with
isSubset
before this change and ~0.05sec after the change.