IBM / jsonsubschema

Tool for checking whether a JSON schema is a subschema of another JSON schema.
Apache License 2.0
85 stars 17 forks source link

Fix join of enum with string #28

Closed kmichel-aiven closed 3 months ago

kmichel-aiven commented 3 months ago

The join of a string restricted by a pattern with an unrestricted string is the unrestricted string, because it contains every possible string.

kmichel-aiven commented 3 months ago

The tests are flaky because of non-repeatable canonicalization: https://github.com/IBM/jsonsubschema/pull/29

I'll also make a PR to fix the underlying bug when escaping regexp in a way that greenery doesn't like.

shinnar commented 3 months ago

when you get a chance, could you please rebase this against the latest?