Consider adding a constraint for the dependency towards python-intervals

IBM / jsonsubschema

Tool for checking whether a JSON schema is a subschema of another JSON schema.

Apache License 2.0

82 stars 17 forks source link

Consider adding a constraint for the dependency towards python-intervals #4

Closed AlexandreDecan closed 4 years ago

AlexandreDecan commented 4 years ago

Hello,

I see that you're relying on python-intervals. I suggest to add a dependency constraint (e.g. <2.0.0) since version 2.0.0 will be released soon, and contains backward incompatible changes (e.g. .is_empty() method will be replaced by .empty property).

AlexandreDecan commented 4 years ago

The newer 2.0.0 version was released today, but should not break your code since it has been released with a new package name (portion has replaced python-intervals).

andrewhabib commented 4 years ago

Hi Alexandre,

Thank you for pointing out the migration to the new package name... I am glad this did not affect our project here. I will look into migrating to the new library. But thanks for a nice and handy project!

AlexandreDecan commented 4 years ago

Hi,

You're welcome. I'm glad to see my library being used by other people ;-) Feel free to contact me if you have questions or need help when migrating to portion!