search

IBM / jupyterlab-s3-browser

A JupyterLab extension for browsing S3-compatible object storage
Apache License 2.0
119 stars 41 forks source link

sidebar-icon at top position #74

Open jhgoebbert opened 2 years ago

jhgoebbert commented 2 years ago

Describe the bug The sidebar icon of jupyterlab-s3-browser is located at the first top position in the left sidebar in our setup. This is IMHO reserved for JupyterLab's filebrowser. So I would consider this as a bug 🤔

image

I have seen screenshots of jupyterlab-s3-browser where this was not the case. Perhaps this bug only appears with a certain JupyterLab version ... we are using 3.4.3

Desktop:

jhgoebbert commented 2 years ago

You set rank to 100 here:
https://github.com/IBM/jupyterlab-s3-browser/blob/master/src/index.ts#L71

If you follow the recommendations for rank from the documentation here https://jupyterlab.readthedocs.io/en/stable/extension/extension_points.html#left-right-areas

    0-500: reserved for first-party JupyterLab extensions.
    501-899: reserved for third-party extensions.
    900: The default rank if none is specified.
    1000: The JupyterLab extension manager.

you might want to change that 501 at least.