Allow transparent usage of s3 interfaces using s3v2 signature_version

IBM / jupyterlab-s3-browser

A JupyterLab extension for browsing S3-compatible object storage

Apache License 2.0

119 stars 41 forks source link

Allow transparent usage of s3 interfaces using s3v2 signature_version #86

Open tktridley opened 1 year ago

tktridley commented 1 year ago

Added a config variable "signature_version" that is set through trying an s3v4 signature first, then falls back to s3v2 through excepting on a ClientError if s3v4 isn't accepted by the s3 interface.

This is required for transparently allowing users to connect to S3 interfaces that cannot be updated to use the s3v4 signature_version.

tktridley commented 1 year ago

Hi, apologies for the issues with DCO. I'm not sure how to solve this issue. Would closing this pull request, rebasing my branch with --signoff, and opening a new pull request (directly from the branch on my fork) be preferable, or is there someway to correct this within this pull request?