IBM / keyprotect-go-client

Go SDK for interacting with the IBM Cloud KeyProtect service.
Apache License 2.0
6 stars 29 forks source link

Ability to add custom headers to SDK via terraform provider #71

Open kavya498 opened 2 years ago

kavya498 commented 2 years ago

We dont see a way pass custom headers to the SDK.. Can we get the ability to add custom headers to SDK?

Ref: https://github.com/IBM/platform-services-go-sdk/blob/a7f14ee285ced3c4ec52b4b56e6cf9011d234b54/resourcecontrollerv2/resource_controller_v2.go#L139

mrodden commented 2 years ago

I don't understand the need for custom headers, when KeyProtect will more or less completely ignore them if they aren't part of the KeyProtect API.

If you could provide your use case for them and it is a valid use case then maybe we could consider it.

I would also have to confirm with the KeyProtect API folks that adding custom headers wouldn't cause any request validation issues.