search

IBM / keyprotect-nodejs-client

Nodejs SDK for interacting with the IBMCloud KeyProtect service.
Apache License 2.0
0 stars 10 forks source link

`npm install` did not get latest code #22

Closed wanghwh closed 1 year ago

wanghwh commented 2 years ago

After install keyprotect client, I got below dependencies. but in our latest code, the version of "ibm-cloud-sdk-core": is 3.10.0. which addressed CVE-2022-36313

"dependencies": { "@types/node": "^12.0.8", "extend": "^3.0.2", "ibm-cloud-sdk-core": "^2.10.0" },

dinesh-venkatraman-g commented 2 years ago

@wanghwh May I know how you are installing the sdk client?

When I did npm install, I could see "ibm-cloud-sdk-core": "^3.1.0" "dependencies": { "@ibm-cloud/platform-services": "^0.20.3", "@types/node": "^12.0.8", "extend": "^3.0.2", "ibm-cloud-sdk-core": "^3.1.0" },

wanghwh commented 2 years ago

I am using npm i at my local and our CICD is using npm ci in docker file

wanghwh commented 1 year ago

still cannot get "ibm-cloud-sdk-core": "^3.1.0"

Rishi-web commented 1 year ago

@wanghwh may i know how you installed the key-protect client ? Also can you share package.json file

Rishi-web commented 1 year ago

@wanghwh are you installing key-protect client like this. npm i @ibm-cloud/ibm-key-protect

Rishi-web commented 1 year ago

@wanghwh are you seeing "ibm-cloud-sdk-core": "^2.10.0" in package-lock.json file ?

Rishi-web commented 1 year ago

@wanghwh we recently published the latest @ibm-cloud/ibm-key-protect - v0.1.5 which should address your concern("ibm-cloud-sdk-core": "^2.10.0"). Please install the latest version and let us know "ibm-cloud-sdk-core" is getting updated to 3.2.0

wanghwh commented 1 year ago

@Rishi-web , sorry did not reply you. with version 0.1.5, I can get "ibm-cloud-sdk-core":3.2.0

but I will create a new issue for upgrading @ibm-cloud/platform-services , which is still depending on "ibm-cloud-sdk-core" 2.x