IBM / lemming

Human in the loop plan selection
Apache License 2.0
5 stars 1 forks source link

Select by edge and not by edge name #51

Closed TathagataChakraborti closed 6 months ago

TathagataChakraborti commented 6 months ago

🐞 Bug

Currently, a disambiguation choice is registered by edge name and not by edge ID which while the algorithms in the backend follow ID. This needs to be consistent.

💡 Feature

The implication here is that when making a selection the user is not only selecting membership but also choice. It's debatable which one is the "right" thing to do. The proposal is to put this in as a mode users can select.

For SELECT mode, this does not make much difference visually. For BUILD forward and backward, the ordered choice will fix the second issue in #41 while for unordered choice the color coding scheme needs to update to only show disambiguating choices in green.

👀 Note that the two options will have an impact on an ordered versus un-ordered plan generation scheme. This needs to be investigated further during the simulations.

TathagataChakraborti commented 6 months ago

Implemented feature: it is possible to select edges either by name or by edge.

This makes the selection process not agnostic to the order of selection and the undo interaction becomes unstable. As a result, undo is now only available on name-based interaction and a global reset of all selections is available for all interactions.

Furthermore, this makes switching between views unstable. If edge-based selection is turned on, we now reset the current interaction.