search

IBM / lmctl

Cloud Pak for Network Automation (CP4NA) (previously ALM/TNCO) command line tool
Apache License 2.0
4 stars 19 forks source link

issue/131 - sol005 driver's compatibility change for lmctl #130

Closed rkumar8j closed 2 years ago

rkumar8j commented 2 years ago

Fixes #131

dvaccarosenna commented 2 years ago

Please raise an issue on this repository for the change. #3383 refers to an issue from an internal system which cannot be used as a reference here.

rkumar8j commented 2 years ago

@dvaccarosenna : There is a minor change I have done in the unit test case file and now everything is on place. Please review the same from your end.

dvaccarosenna commented 2 years ago

Also need to ensure any documentation is updated. We at least need to add the new sol005 option to the command reference for lmctl project create: https://github.com/IBM/lmctl/blob/master/docs/command-reference/project/create.md#params

Has this doc change been made?

rkumar8j commented 2 years ago

Hi @dvaccarosenna : One separate issue is already raised for document updates. [REDACTED]

As of now, this PR can be approved and document will be updated with the above issue.

dvaccarosenna commented 2 years ago

Hi @rkumar8j let's not use internal issue links here, as this is a public repo. The issue you refer to is for updating the official product documentation but this PR needs to update the docs in this repo, located at https://github.com/IBM/lmctl/blob/master/docs.

This forms the basis for the official documentation, but the changes need to be applied here first.

rkumar8j commented 2 years ago

Hi @dvaccarosenna : I have updated the document wrt sol005 driver. Kindly let me know if need any further update.