search

IBM / lunchpail

Lunchpail compiles your job code into an all-in-one executable. Others download that binary, and "up" it to run your code in the Cloud or an existing Kubernetes cluster.
Apache License 2.0
4 stars 2 forks source link

fix: apps that use an rclone config may not be down-able #249

Open starpit opened 1 week ago

starpit commented 1 week ago

Describe the bug If the rclone config file in question used for up is not available on the machine doing down, then the down will fail. This is because down depends on templating the application into the llir, in order to know which resources to delete. And the templating step looks for the rclone config file...

To Reproduce Steps to reproduce the behavior:

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

starpit commented 1 week ago

one fix would be to have down instead just kill all runname-labeled resources. we could leverage the GetAllResourcesFromSelector from odo. https://github.com/redhat-developer/odo/blob/main/pkg/kclient/all.go

alternatively, we could somehow render rclone config file loading into warnings when doing down...