IBM / mi-prometheus

Enabling reproducible Machine Learning research
http://mi-prometheus.rtfd.io/
Apache License 2.0
42 stars 18 forks source link

Use LGTM and flake8 to find some missing imports #110

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

flake8 testing of https://github.com/IBM/mi-prometheus on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./miprometheus/problems/seq_to_seq/algorithmic/recall/scratch_pad_cl.py:176:18: F821 undefined name 'ScratchPad'
    scratchpad = ScratchPad(params)
                 ^
./miprometheus/problems/seq_to_seq/vqa/cog/cog_utils/stim_generator.py:758:5: F821 undefined name 'save_movie'
    save_movie(movie, save_name, t_total)
    ^
./miprometheus/problems/seq_to_seq/vqa/cog/cog_utils/stim_generator.py:797:5: F821 undefined name 'save_movie'
    save_movie(movie, save_name, t_total)
    ^
3     F821 undefined name 'ScratchPad'
3

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.

tkornuta-ibm commented 5 years ago

Hi, @cclauss thanks for your work, we were participating in NeurIPS last week, will investigate the raised issue as soon as possible.