search

IBM / mi-prometheus

Enabling reproducible Machine Learning research
http://mi-prometheus.rtfd.io/
Apache License 2.0
42 stars 18 forks source link

Undefined name: seq_length --> seq_lengths #145

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

Blocked by #146 bacause LGTM will continue running the old analytics until AFTER the .lgtm.yml file is deleted from the repo.

seq_length (singular) is an undefined name in this context so this PR proposes to use seq_lengths (plural) instead.

flake8 testing of https://github.com/IBM/mi-prometheus on Python 3.7.1

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./miprometheus/problems/seq_to_seq/algorithmic/recall/scratch_pad_cl.py:158:92: F821 undefined name 'seq_length'
        data_dict['sequences_length'] = torch.ones([batch_size,1]).type(torch.IntTensor) * seq_length
                                                                                           ^
1     F821 undefined name 'seq_length'
1

LGTM.com does not want flake8 to be run on their infrastructure so remove .lgtm.yml and move the flake8 tests back to Travis CI.

Remove flake8 packages from requirements.txt because they are used only at test time and are not runtime requirements for mi-prometheus.