search

IBM / mi-prometheus

Enabling reproducible Machine Learning research
http://mi-prometheus.rtfd.io/
Apache License 2.0
42 stars 18 forks source link

Refactor videotoclass #71

Closed sesevgen closed 5 years ago

sesevgen commented 5 years ago

Addresses #58

Unit tests for both problems work, but I haven't tested a model.

tkornuta-ibm commented 5 years ago

This pull request introduces 1 alert when merging d4e35b3977c4e1d7ee93eef4e4264351e9b21c53 into 194cedec3431c7b56d1c1b2fed1a6e75e9fec265 - view on LGTM.com

new alerts:

Comment posted by LGTM.com

sesevgen commented 5 years ago

If we can wait a bit on this, I'd like to improve the unit tests to check whether all the data structures match the expected formats.

EDIT: Updated the unit tests, please review.

sesevgen commented 5 years ago

Addressed changes requested above.

tkornuta-ibm commented 5 years ago

Fixed #58