bAbI refactored - Githubissues

IBM / mi-prometheus

Enabling reproducible Machine Learning research

http://mi-prometheus.rtfd.io/

Apache License 2.0

42 stars 18 forks source link

bAbI refactored #97

Open vincentalbouy opened 5 years ago

vincentalbouy commented 5 years ago

Ok guys I open this pull request if you want to have a look, I need feedbacks. For now it contains a refactored versions of the work of Ryan. It contains:

A modified seq2seq_problem.py
A babi.yaml to run babi with LSTM
A first draft of BABI problem Class

I think the problem Class needs a lot of improvement, I noticed Ryan didn't use any padding so I am working on a new version with Pack_padded_sequence as @vmarois suggested. Also the story parsing method was not commented so I had a hard time understanding what he did so I am not 100% sure the parsing is correct.

tkornuta-ibm commented 5 years ago

This pull request introduces 3 alerts when merging ddb720b1ec7951b8f7a72cda5cdf52ef1f446fcc into 68ad04da795c2d5e8ecb86144cb459a28ac1aa71 - view on LGTM.com

new alerts:

1 for Non-callable called
1 for Unused local variable
1 for Missing call to __init__ during object initialization

Comment posted by LGTM.com

tkornuta-ibm commented 5 years ago

Finally, can we agree that we will use the right name It should be

bAbI

not Babi, BABI etc.

And it is for a reason

https://research.fb.com/downloads/babi/

bAbI from "baby AI"

And besides, it is only bAbI QA, not the whole bAbI, which contains more tasks...

tkornuta-ibm commented 5 years ago

This pull request introduces 4 alerts when merging 0c052d404ea0f7b996b24dac78c26359f6ba0d1c into 3d4f868320c8914f37543298c634ab6ba6a1425d - view on LGTM.com

new alerts:

1 for Non-callable called
1 for Unused local variable
1 for Unused import
1 for Missing call to __init__ during object initialization

Comment posted by LGTM.com