Closed vmarois closed 5 years ago
@tkornut I've pushed some commits that:
multi_test
key from the config so that the testing_configuration.yaml
in each test folder does not contain it,logger.FileHandler
of the Tester
so that tester.log
in each test folder only contains the logs of the current experiment (wasn't the case previously),@aasseman : The bug where a config
param is also present in the default
ones is still there.. So only doing params.del_config_param(key='config_key')
does not work on its own, we have to add params.del_default_param(key='config_key')
. That's how I am getting around it, so let's not spend time on this bug for now (as this is the only place in mip
where we need this feature). I'm opening an issue for reference though.
Update: I'm fairly confident that I have fixed the bug where adding config
params would also add them to the default
ones. See https://github.com/IBM/mi-prometheus/commit/2ffcc710c7549d113f85de1d007d5668c43c9339
@tkornut Can you review that PR?
Update:
I've loosen the constraint on the 'testing problem' section: The user can now change leafs of the entire testing
configuration section.
In this PR, I am adding support for multi-tests in
Tester
. It is basic, and somewhat constrained, but it worked forSimpleConvNet/MNIST
.If the user would like to run multiple tests, he can use the
multi_tests
key in thetesting
section to indicate the keys which associated values will be different for each test config:The following constraints apply for now:
testing
sectionand
will lead to different test configs.
I am mainly opening this PR for code review & feedback, as this is still very basic for now. I want to test how this plays with more complex configs (e.g. when
sampler
is present).