IBM / networking-go-sdk

IBM Cloud Networking Services Go SDK
Apache License 2.0
9 stars 11 forks source link

CodeQL for Github Action not failing on test case failures #109

Open arpit-srivastava-ibm opened 1 year ago

arpit-srivastava-ibm commented 1 year ago

Describe the bug We noted that Build for Github Action did not fail even after the test cases failed.

To Reproduce

Expected behavior It is expected for Github Action to fail, as the test cases have failed.

Screenshots

image

Must gather (please complete the following information):

Additional context It is expected for Github Action to fail, if the test cases are failing. This breaks the basic idea of building and testing the PR before merging it to the master. Point to mention that we have Travis build for merge commits only.

arpit-srivastava-ibm commented 1 year ago

@moisesatwork I believe we will need to write custom scripts for CodeQL to run the build in the first place. Right now, the build is auto generated, hence most of the test cases are skipped.

Also, 1 more important point to note here is that the integration test cases need env files to run, which we will have to encrypt in order to use during the build. (Similar to how we do for Travis builds)