IBM / node-odbc

ODBC bindings for node
MIT License
143 stars 75 forks source link

add -fno-permissive to avoid invalid conversion from ‘napi_finalize’ {aka ‘void (*)(napi_env__*, void*, void*)’} to ‘node_api_nogc_finalize’ #394

Closed phpdave closed 3 weeks ago

phpdave commented 1 month ago

probably not the best option but gets it to build and stops the error

invalid conversion from ‘napi_finalize’ {aka ‘void (*)(napi_env__*, void*, void*)’} to ‘node_api_nogc_finalize’

partially for https://github.com/IBM/node-odbc/issues/392 . Solves my immediate issue but doesn't solve that there isn't pre-built binaries for ppc64le and build time errors are occurring from dependency changes else where in node ecosystem.

Note i still need to test and verify if ignoring the issue above causes other problems

kadler commented 3 weeks ago

No longer needed since #381