search

IBM / nodejs-idb-connector

A JavaScript (Node.js) library for communicating with Db2 for IBM i, with support for queries, procedures, and much more. Uses traditional callback-style syntax
MIT License
37 stars 23 forks source link

Get Enumeration to FieldTypes #115

Closed joaojmendes closed 4 years ago

joaojmendes commented 4 years ago

Please add enum to FieldTypes.

When we get fieldTypes(i) we get number id not the description of fieldtype.

thank you.

kadler commented 4 years ago

While I agree it would be better to return a more useful type string, these types can be compared to those exported here: https://github.com/IBM/nodejs-idb-connector/blob/master/lib/db2a.js#L337-L377

joaojmendes commented 4 years ago

Thank tou! Is that I use now. 😊

From: Kevin Adler notifications@github.com Reply to: IBM/nodejs-idb-connector reply@reply.github.com Date: Wednesday, 6 May 2020 at 04:59 To: IBM/nodejs-idb-connector nodejs-idb-connector@noreply.github.com Cc: João Mendes joao.j.mendes@outlook.com, Author author@noreply.github.com Subject: Re: [IBM/nodejs-idb-connector] Get Enumeration to FieldTypes (#115)

While I agree it would be better to return a more useful type string, these types can be compared to those exported here: https://github.com/IBM/nodejs-idb-connector/blob/master/lib/db2a.js#L337-L377

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/IBM/nodejs-idb-connector/issues/115#issuecomment-624429272, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC7YHVO6YJ3VOQ4KVE6KXTLRQDOAFANCNFSM4MNPXNLQ.

dmabupt commented 4 years ago

Current field* APIs are redundant. I would like to use an unique function (maybe called fieldInfo**) to provide all the information of the column, including type, width, nullable, etc. And update it with more properties (like #116) in feature.

dmabupt commented 4 years ago

Hello @joaojmendes , The PR is drafted at #118 . If no problem, I will merge it later.

joaojmendes commented 4 years ago

Hello, @Xu Mengmailto:notifications@github.com

Thank you for the answer.

Yes seem a good solution to have one object with all information about column.

Thank you ! João

From: Xu Meng notifications@github.com Reply to: IBM/nodejs-idb-connector reply@reply.github.com Date: Thursday, 14 May 2020 at 06:45 To: IBM/nodejs-idb-connector nodejs-idb-connector@noreply.github.com Cc: João Mendes joao.j.mendes@outlook.com, Author author@noreply.github.com Subject: Re: [IBM/nodejs-idb-connector] Get Enumeration to FieldTypes (#115)

I would like to add a new function (maybe called fieldInfo) to provide all the information of the column, including type, width, nullable, etc.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/IBM/nodejs-idb-connector/issues/115#issuecomment-628400893, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC7YHVLDTEK2HFGAZIH45HLRROARHANCNFSM4MNPXNLQ.

dmabupt commented 4 years ago

Close this issue since idb-connector v1.2.9 is released now. This new version contains the new API to resolve the issue.