search

IBM / nodejs-idb-connector

A JavaScript (Node.js) library for communicating with Db2 for IBM i, with support for queries, procedures, and much more. Uses traditional callback-style syntax
MIT License
37 stars 23 forks source link

fix: Binding parameters issues #157

Closed abmusse closed 1 year ago

abmusse commented 1 year ago

Resolves https://github.com/IBM/nodejs-idb-connector/issues/147#issuecomment-1208227784

https://github.com/IBM/nodejs-idb-connector/issues/147#issuecomment-1257673673

We now set SQL_NTS as the indicator instead of the string length.

This helps in edge cases like empty string where indicator is set to 0. Also we now ensure the buffer size is at least the size of parameter or the size of the string.

patrickhrastnik commented 1 year ago

Thanks for fixing this bug @abmusse Can you give us an estimate on when the fix will be rolled out in a new version of idb-connector? According to Releases tab the last version was rolled out in April. It'll help us scheduling our next steps to integrate the fix

patrickhrastnik commented 1 year ago

Furthermore, I'd need to know when idb-pconnector will be upgraded to use the new version of idb-connector. That's the package we're actually using.

abmusse commented 1 year ago

@patrickhrastnik

I'm working on getting both packages released today. Thanks!