search

IBM / nodejs-idb-connector

A JavaScript (Node.js) library for communicating with Db2 for IBM i, with support for queries, procedures, and much more. Uses traditional callback-style syntax
MIT License
38 stars 23 forks source link

ci: update release process #177

Closed abmusse closed 5 months ago

abmusse commented 11 months ago

For more details on the release process, please read docs/RELEASE.md

In previous releases, we packaged the db2ia.node and other extra files

Now we restrict the files packaged using the files section of the package.json

https://docs.npmjs.com/cli/v8/configuring-npm/package-json#files

abmusse commented 11 months ago

That sounds good to me as well!

github-actions[bot] commented 10 months ago

:wave: Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

abmusse commented 10 months ago

polite ping @kadler

Looks good, thought I think some of this stuff could be moved outside of the root. Both the release.sh and README section are really only relevant to us. Perhaps moving the docs to docs/RELEASE.md and putting release.sh under .github?

Can you please re-review after I moved files around as this PR is now going stale 😄

The steps for the release process are defined in https://github.com/IBM/nodejs-idb-connector/blob/44065d373c458ae697294f9dee8ba9956bbc7ee9/docs/RELEASE.md Let me know if this needs some changes.