IBM / openapi-to-graphql

Translate APIs described by OpenAPI Specifications (OAS) into GraphQL
https://developer.ibm.com/open/projects/openapi-to-graphql/
MIT License
1.61k stars 211 forks source link

Extend OAS implementations #440

Closed eokoneyo closed 2 years ago

eokoneyo commented 2 years ago

Hi, following our discussion in https://github.com/IBM/openapi-to-graphql/pull/426 , I decided to open a different PR to tackle couple of issues I found pertaining to how the definitions from an OAS might be processed.

Here's a couple of issues the PR addresses;

Alan-Cha commented 2 years ago

@eokoneyo Thank you so much for the follow up! I will take a closer look at this later today and try to get it in. This is looking great so far!

Alan-Cha commented 2 years ago

Okay, I have reviewed this and I generally like what I see! I have a few comments, however, which I will try to address. All in all, I think we can merge this in!

Alan-Cha commented 2 years ago

@eokoneyo It's in! Thanks so much again! I know this fix and the old PR has been getting really stale. This was a really great change! Thank you once again!