fix: use single logger instance - Githubissues

IBM / openapi-validator

Configurable and extensible validator/linter for OpenAPI documents

Apache License 2.0

483 stars 88 forks source link

fix: use single logger instance #623

Closed padamstx closed 1 year ago

padamstx commented 1 year ago

PR summary

This PR makes sure that the validator and all rules use a single global instance of the LoggerFactory.

PR Checklist

General checklist

Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[x] Dependencies have been updated as needed
[ ] .secrets.baseline updated as needed?

Checklist for adding a new validation rule:

[ ] Added new validation rule definition (packages/ruleset/src/rules/*.js, index.js)
[ ] If necessary, added new validation rule implementation (packages/ruleset/src/functions/*.js, updated index.js)
[ ] Added new rule to default configuration (packages/ruleset/src/ibm-oas.js)
[ ] Added tests for new rule (packages/ruleset/test/*.test.js)
[ ] Added docs for new rule (docs/ibm-cloud-rules.md)

padamstx commented 1 year ago

Looks good!

I noticed the line static _factory = null; is still present in the logger factory file

good catch... with all the excitement related to this PR I completely whiffed at removing that line :joy:

ibm-devx-sdk commented 1 year ago

:tada: This PR is included in version 1.2.1 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

ibm-devx-sdk commented 1 year ago

:tada: This PR is included in version 1.6.1 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket: