fix(build): build executables with correct dependency versions

padamstx commented 7 months ago

PR summary

This commit modifies the create-binaries.sh script so that it removes the packages/validator/node_moduels/@ibm-cloud directory prior to invoking pkg to build the executables. This fixes a problem where the executables would end up with the "old" version of the openapi-ruleset dependency in situations where we're also publishing a new version of that dependency. Removing the dependency from packages/validator/node_modules means that pkg would end up using the dependencies in the project's top-level "node_modules" directory instead, which will have the correct version of the dependency.

PR Checklist

General checklist

Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[x] Dependencies have been updated as needed
[x] .secrets.baseline updated as needed?

Checklist for adding a new validation rule:

[ ] Added new validation rule definition (packages/ruleset/src/rules/*.js, index.js)
[ ] If necessary, added new validation rule implementation (packages/ruleset/src/functions/*.js, updated index.js)
[ ] Added new rule to default configuration (packages/ruleset/src/ibm-oas.js)
[ ] Added tests for new rule (packages/ruleset/test/*.test.js)
[ ] Added docs for new rule (docs/ibm-cloud-rules.md)