search

IBM / operator-for-redis-cluster

IBM Operator for Redis Cluster
https://ibm.github.io/operator-for-redis-cluster
MIT License
60 stars 34 forks source link

PodDisruptionBudget not updated when RedisCluster update #104

Open takumakume opened 1 year ago

takumakume commented 1 year ago

Problems

I am using v0.3.14 and found a problem that MinAvailable of PodDisruptionBudget is not updated when NumberOfPrimaries and ReplicationFactor of RedisCluster are updated.

Proposal

Add processing to recalculate and update MinAvailable of PodDisruptionBudget in reconcil of RedisCluster.

cin commented 1 year ago

Thanks for the PR @takumakume! Sorry for the delay. I'll take a look at the PR ASAP (will probably be a couple of days though).

takumakume commented 1 year ago

I understand if you're busy, but could we confirm? @cin

cin commented 1 year ago

Sorry @takumakume. Unfortunately, I don't think anyone actively maintains this project anymore at IBM. I've been slowly working on migrating this over to a fork -- here. Hopefully I'll get some time to work on it this week. It would be cool to get someone to periodically merge things into this repo though.

takumakume commented 1 year ago

I see. Does this mean that the Pull Request for this Issue is not going to be merged?

My team uses IBM/operator-for-redis-cluster in multiple production environments. (Thank you for everything)

It is an important element and I will continue to be proactive in maintaining operator-for-redis-cluster.

Now that I understand the situation, I too will fork temporarily. At least until the @cin repository becomes active.

gautamabhishek46 commented 9 months ago

Hy @takumakume were you able to test your change and use it in production ?