search

IBM / page-lab

PageLab enables web performance, accessibility, SEO, etc testing at scale.
Apache License 2.0
19 stars 10 forks source link

Check that LighthouseRun queries filter out 'invalid_run' ones #23

Closed ecumike closed 5 years ago

ecumike commented 6 years ago

For methods that query LighthouseRun or calculate averages, verify/update them to ensure they filter out LighthouseRun that have invalid_run set.

Best way is to probably create a queryset manager for LighthouseRun so it can be common used wherever needed.

For obvious reasons... we want to ensure we don't calculate averages using runs that were 'invalid' as to skew the real average performance for the URL

ecumike commented 5 years ago

Confirmed working as expected, but need to move filter into a queryset for cleaner code maintenance and reusability. Todo: make LighthouseRunManager at top of models just like URL. Use line 666 filter for condition.

ecumike commented 5 years ago

Handled in #59