search

IBM / page-lab

PageLab enables web performance, accessibility, SEO, etc testing at scale.
Apache License 2.0
19 stars 10 forks source link

First pass of UI for URL filters. #46

Closed rcalfredson closed 5 years ago

rcalfredson commented 5 years ago

Builds on P.R. #36, and is linked to issue 28.

Approach and design consists of two primary UI additions: 1) a list of all filters, with links to jump to a filtered view of the dashboard or the heads-up display and 2) a drop-down selector on both of those types of displays that allows the applied filter to be swapped out.

daviddahl commented 5 years ago

Just a note, we have a massive re-factor of the CSS /front end happening and plan to review and merge this afterward

ecumike commented 5 years ago

Hey Robert... I hate to do this to you, but we totally revamped the app and the template code last week and we aren't using IBM's design system anymore.

I'll give you two choices you can pick...

  1. You can pull in master and update your code in this PR to resolve conflicts.
  2. I'll merge this PR into a dev branch and do updates and stuff for you and then merge (because I'm feeling in the holiday spirit :) ).
ecumike commented 5 years ago

OH wait, my bad Robert... we haven't merged it yet. It's still a PR: #52 . Just let me know if you want to update your PR, or if you want me to do it, as mentioned, and we'll go from there.

rcalfredson commented 5 years ago

Thank you for the update! I am game to apply the updates, but am wanting first to get the opinion of my team on it. Will have update here soon.

rcalfredson commented 5 years ago

As update to this, merging of fade-to-black branch into this one is now complete and successful! Here is link to comparison of those two directly, which may be easier to reference because this P.R. now contains the changes of both of those branches. Just to confirm, all references to the IBM style classes have been removed and replaced with their analogs from template_helpers.

ecumike commented 5 years ago

Hey Robert... curious what's the/your status on this PR? I pulled your branch and it worked. Just curious if you are 'done' and we can merge it.

Main reason is that I have changes I'm working on and I hate to have you keep updating this PR just to merge in/fix conflicts because of that.

rcalfredson commented 5 years ago

For this branch, there is nothing more that I anticipate to add, and so I think its status is "done." Fortunately, yesterday Ann Marie uncovered one bug with it, which is that the Dashboard view was not rendering correctly for the case where a filter has no results, and that is resolved with the most recent commit!

ecumike commented 5 years ago

OK cool. I fill finish up my feature then work on merging all this stuff together. Thanks!