IBM / page-lab

PageLab enables web performance, accessibility, SEO, etc testing at scale.
Apache License 2.0
19 stars 10 forks source link

import datetime for line 68 #75

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

The issue on line 77 is also worth fixing because undefined names have the potential to raise NameError at runtime.

flake8 testing of https://github.com/IBM/page-lab on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./admin/pageaudit/report/import_csv.py:67:75: F821 undefined name 'datetime'
                run_data = LighthouseRun.objects.filter(created_date__gte=datetime.date(y, m, d))
                                                                          ^
./admin/pageaudit/report/import_csv.py:76:44: F821 undefined name 'LighthouseDataUsertiming'
                    user_timing_data = str(LighthouseDataUsertiming.objects.get(lighthouse_run=run).report_data)
                                           ^
2     F821 undefined name 'datetime'
2
ecumike commented 5 years ago

Thanks!