IBM / page-lab

PageLab enables web performance, accessibility, SEO, etc testing at scale.
Apache License 2.0
19 stars 10 forks source link

Undefined name: 'LighthouseDataUsertiming' in import_csv.py #82

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

flake8 testing of https://github.com/IBM/page-lab on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./admin/pageaudit/report/import_csv.py:77:44: F821 undefined name 'LighthouseDataUsertiming'
                    user_timing_data = str(LighthouseDataUsertiming.objects.get(lighthouse_run=run).report_data)
                                           ^
1     F821 undefined name 'LighthouseDataUsertiming'
1

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.

daviddahl commented 5 years ago

Thanks for finding this.

This file was recently under some fast and quick development and is not a core piece of the running server code.

Cheers!