Closed michaelbeck closed 1 year ago
@michaelbeck Looks like your PR build had some linter errors. Based on the messages, I'm guessing that you defined the same function in both the integration tests and examples code. Unfortunately, when we run the linter we use --build-tags=integration,examples
which means all the code inside the service package directory will be "seen" by the linter and since all the code is part of the same package, the linter detects that the functions are actually defined twice in the two different source files. I guess the easiest solution is to rename the functions in one of the files so they're unique.
BTW, each SDK has some detailed developer instructions in the update_service.md
file (linked from CONTRIBUTING.md), but specifically... you can run make all
in your local sandbox and it will run the unit test and linter steps, similar to an automated Travis run. That way you can head off errors like this before pushing your changes to remote, etc.
@michaelbeck Looks like your PR build had some linter errors. Based on the messages, I'm guessing that you defined the same function in both the integration tests and examples code. Unfortunately, when we run the linter we use
--build-tags=integration,examples
which means all the code inside the service package directory will be "seen" by the linter and since all the code is part of the same package, the linter detects that the functions are actually defined twice in the two different source files. I guess the easiest solution is to rename the functions in one of the files so they're unique.
Sorry, I just ran them separately, thus I wouldn't notice. Should be corrected now.
BTW, each SDK has some detailed developer instructions in the
update_service.md
file (linked from CONTRIBUTING.md), but specifically... you can runmake all
in your local sandbox and it will run the unit test and linter steps, similar to an automated Travis run. That way you can head off errors like this before pushing your changes to remote, etc.
I tried to respect what was written in the readmes there. But neither go test
nor go test ./...
seemed to run any meaningful test, so I ignored them. Sorry :-(
:tada: This PR is included in version 0.42.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
PR summary
Added support for IAM enterprise feature. Enterprise admins can create templates for account settings and trusted profiles and assign them to accounts and account groups in the enterprise.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
SDK adopters will be able to work with IAM enterprise feature.
Does this PR introduce a breaking change?
Other information
API definition: Staging
Test information:
Integration Tests:
Examples: