search

IBM / plex

The package of IBM’s typeface, IBM Plex.
SIL Open Font License 1.1
9.69k stars 576 forks source link

fix: condensed preferred name and font weight truncation #324

Closed vpicone closed 4 years ago

vpicone commented 4 years ago

fixes #316

This adds an optional property, preferredName which allows users to override the file/directory with a preferred name in the event that it differs from the type property.

This feature was added so that we could keep the preferred naming convention for IBM Plex Sans Condensed while still being able to generate the truncated local font names (IBM Plex Sans Cond).

Since we don't commit the generated scss files, I created a second repo to show the diff between the current and propsed styles being generated: https://github.com/vpicone/plex-scss-output/pull/1/files

Note: still waiting on https://github.com/IBM/plex/issues/316#issuecomment-647636616 to find out whether Condensed/Cond is supposed to come after the hyphen in the PS name.

vpicone commented 4 years ago

@BoldMonday can you check this git diff between the currently generated styles and the styles generated after this PR and verify the new local values are correct? https://github.com/vpicone/plex-scss-output/pull/3/files