search

IBM / pyflowgraph

Flow graphs for Python
Apache License 2.0
25 stars 8 forks source link

Python 2.7 compatibility fixes #4

Closed epatters closed 6 years ago

epatters commented 6 years ago

Fixes #3.

The problems with the integration tests are mostly related to the non-existence of qualified names in Python 2 (see PEP 3155). At some point we need to get our story straight on this issue, but that's out of scope for this PR.

epatters commented 6 years ago

The tests were failing before the commits and are passing after them. This will be more clear once Travis CI is set up but for simplicity I wanted to take care of these dependency problems first.

epatters commented 6 years ago

I had to rebase against master anyway to resolve merge conflicts, so I addressed your comments while rebasing.

ioana-blue commented 6 years ago

LGTM

epatters commented 6 years ago

Great, thanks.